Skip to content

feat(nx-plugin): adjust bin path handling #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Oct 25, 2025
Merged

feat(nx-plugin): adjust bin path handling #1109

merged 63 commits into from
Oct 25, 2025

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 5, 2025 •
edited
Loading

Precondition:

This PR includes:

  • allows us to execute the repositories code of:
    • cli project'
    • nx-plugin projects executors (not the target inference)
  • removes pluginBin option as it would only help product development and is not working with dependent bundles
  • more intuitive naming

Note

After this is merged is should be possible to use it locally like this:

_nx.json.defaultTargets

"code-pushup": {
      "dependsOn": ["cli:build", "nx-plugin:build"],
      "executor": "@copde-pushup/nx-plugin:cli",
      "options": {
        "bin": "./packages/cli/dist",
        "env": {
          "NODE_OPTIONS": "--import tsx",
          "TSX_TSCONFIG_PATH": "tsconfig.base.json"
        }
    }
}

or

nx.json.plugins

{
      "plugin": "@code-pushup/nx-plugin",
      "options": {
        "bin": "./packages/cli/dist",
        "env": {
          "NODE_OPTIONS": "--import tsx",
          "TSX_TSCONFIG_PATH": "tsconfig.base.json"
        }
    }
}

Then run: nx code-pushup

You will see a log that prints the executed command as copy past version for you to re-ensure the setup.
NODE_OPTIONS="--import tsx" TSX_TSCONFIG_PATH="tsconfig.base.json" npx @code-pushup/cli --verbose --no-progress --config="code-pushup.config.ts" --upload.project="cli-workspace"

The only thing that is left but blocked by Nx, is using the local target inference code with external dependencies.

Another precondition of:

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 nx-plugin labels Sep 5, 2025
@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f8c425a

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 54s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m 4s View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 42s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-23 15:58:14 UTC

@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 695acbc

☁️ Nx Cloud last updated this comment at 2025-09-05 17:32:01 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1109

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1109

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1109

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1109

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1109

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1109

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1109

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1109

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1109

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1109

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1109

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1109

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1109

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1109

commit: f8c425a

@BioPhoton BioPhoton mentioned this pull request Sep 5, 2025
Open
3 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 970a665 with previous commit f335d20.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Updates 🟡 81 🟡 73 ↓ −7.7
Performance 🔴 32 🔴 34 ↑ +1.9
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🟡 56 🟡 56 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Type Safety 🟢 100 🟢 100 –
Bug prevention 🟢 100 🟢 100 –
Miscellaneous 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
Documentation 🔴 36 🔴 36 –
👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM outdated dependencies 🟡 81 🟡 73 ↓ −7.7
Lighthouse Performance 🔴 32 🔴 34 ↑ +1.9
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 8.5 s 🟥 7.3 s ↓ −13.5 %
JS Packages Outdated NPM dev dependencies. 🟨 59 outdated package versions (28 major, 23 minor, 8 patch) 🟨 59 outdated package versions (34 major, 17 minor, 8 patch) +0 %
JS Packages Outdated NPM prod dependencies. 🟨 16 outdated package versions (4 major, 8 minor, 4 patch) 🟨 16 outdated package versions (6 major, 6 minor, 4 patch) +0 %
Lighthouse Total Blocking Time 🟥 2,650 ms 🟥 2,110 ms ↓ −20.4 %
Code coverage Branch coverage 🟨 85.8 % 🟨 85.9 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,023 KiB 🟩 Total size was 2,019 KiB ↓ −0.2 %
Lighthouse Minimizes main-thread work 🟥 14.6 s 🟥 13.5 s ↓ −7.8 %
Lighthouse Largest Contentful Paint 🟥 11.7 s 🟥 11.3 s ↓ −3.7 %
Lighthouse Server Backend Latencies 🟩 140 ms 🟩 550 ms ↑ +298.8 %
Lighthouse Initial server response time was short 🟥 Root document took 820 ms 🟥 Root document took 630 ms ↓ −22.9 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.2 %
Lighthouse Time to Interactive 🟥 13.9 s 🟥 14.1 s ↑ +1.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 180 KiB ↑ +21.3 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 103 KiB ↑ +53.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Max Potential First Input Delay 🟥 1,660 ms 🟥 1,580 ms ↓ −4.8 %
Lighthouse JavaScript execution time 🟥 5.7 s 🟥 5.6 s ↓ −1.2 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 40 ms ↓ −41.2 %
Lighthouse First Contentful Paint 🟥 3.2 s 🟥 3.2 s ↓ −0.4 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 103 KiB 🟥 Potential savings of 103 KiB ↑ +2.2 %
Code coverage Line coverage 🟨 86.6 % 🟨 86.6 % ↑ +0.1 %

589 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 5, 2025 17:29
@BioPhoton BioPhoton requested a review from matejchalk September 5, 2025 17:38
@github-actions github-actions bot removed the 🧩 ci label Sep 9, 2025
BioPhoton
BioPhoton commented Sep 9, 2025
View reviewed changes
@github-actions github-actions bot removed the 📖 Project documentation improvements or additions to the project documentation label Sep 9, 2025
@github-actions github-actions bot added the 📖 Project documentation improvements or additions to the project documentation label Oct 4, 2025
@BioPhoton BioPhoton requested a review from matejchalk October 23, 2025 14:11
matejchalk
matejchalk reviewed Oct 23, 2025
View reviewed changes
BioPhoton and others added 5 commits October 23, 2025 17:41
@BioPhoton @matejchalk
Update packages/nx-plugin/src/plugin/target/executor-target.ts
e5c82df 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/nx-plugin/src/plugin/target/executor.target.unit.test.ts
60697d7 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
refactor: adjust logic
340d700
Merge remote-tracking branch 'origin/feat/plugin-nx/allow-unreleased-…
28c48dd 
…code' into feat/plugin-nx/allow-unreleased-code
refactor: adjust logic 2
f8c425a
@BioPhoton BioPhoton requested a review from matejchalk October 23, 2025 15:49
@BioPhoton BioPhoton merged commit fbb5c9b into main Oct 25, 2025
21 of 22 checks passed
@BioPhoton BioPhoton deleted the feat/plugin-nx/allow-unreleased-code branch October 25, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalk matejchalk matejchalk approved these changes

Assignees

@BioPhoton BioPhoton

Labels

🧩 nx-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BioPhoton @matejchalk